← Back to team overview

wordpress-charmers team mailing list archive

Re: [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

 

One comment inline

Diff comments:

> diff --git a/fetcher.py b/fetcher.py
> index 9f93073..eb6c0b5 100755
> --- a/fetcher.py
> +++ b/fetcher.py
> @@ -110,7 +110,7 @@ def get_themes(branch_themes):
>      current_branch = 0
>      for branch_theme in branch_themes:
>          current_branch = current_branch + 1
> -        print('Downloading branched theme {} of {}...'.format(current_branch, total_branches))
> +        print('Downloading branched theme {} of {}: {} ...'.format(current_branch, total_branches, branch_theme))

The format I was using was:

print('Downloading {} of {} branched plugins: {} ...'.format(current_branch, total_branches, branch_plugin)) 

Would be good to be consistent I think

>          url = branch_themes[branch_theme].get('url')
>          basename = os.path.basename(url)
>          if basename.startswith('lp:'):


-- 
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/377649
Your team Wordpress Charmers is requested to review the proposed merge of ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.


References