wordpress-charmers team mailing list archive

[Tom Haddon <tom.haddon@xxxxxxxxxxxxx>]

Tom Haddon has proposed merging ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:better-import-warnings into charm-k8s-wordpress:master.

Commit message:
Clean up how we're using noqa E402 by using it on the line causing the later warnings



Requested reviews:
  Wordpress Charmers (wordpress-charmers)

For more details, see:
https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/383769

Clean up how we're using noqa E402 by using it on the line causing the later warnings


-- 
Your team Wordpress Charmers is requested to review the proposed merge of ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:better-import-warnings into charm-k8s-wordpress:master.

diff --git a/src/charm.py b/src/charm.py
index 9fcf4b4..e9c87ee 100755
--- a/src/charm.py
+++ b/src/charm.py
@@ -8,12 +8,12 @@ from yaml import safe_load
 
 from wordpress import Wordpress
 
-sys.path.append("lib")
+sys.path.append("lib")  # noqa: E402
 
-from ops.charm import CharmBase, CharmEvents  # NoQA: E402
-from ops.framework import EventBase, EventSource, StoredState  # NoQA: E402
-from ops.main import main  # NoQA: E402
-from ops.model import ActiveStatus, BlockedStatus, MaintenanceStatus, WaitingStatus  # NoQA: E402
+from ops.charm import CharmBase, CharmEvents
+from ops.framework import EventBase, EventSource, StoredState
+from ops.main import main
+from ops.model import ActiveStatus, BlockedStatus, MaintenanceStatus, WaitingStatus
 
 logger = logging.getLogger()
 
diff --git a/tests/unit/test_charm.py b/tests/unit/test_charm.py
index 1ad1e19..f0578cd 100644
--- a/tests/unit/test_charm.py
+++ b/tests/unit/test_charm.py
@@ -4,8 +4,8 @@ import copy
 import unittest
 import sys
 
-sys.path.append('lib')  # noqa
-sys.path.append('src')  # noqa
+sys.path.append('lib')  # noqa: E402
+sys.path.append('src')  # noqa: E402
 
 from charm import WordpressK8sCharm
 from ops import testing
diff --git a/tests/unit/test_wordpress.py b/tests/unit/test_wordpress.py
index 13b29d2..af417ec 100644
--- a/tests/unit/test_wordpress.py
+++ b/tests/unit/test_wordpress.py
@@ -6,10 +6,10 @@ import sys
 import unittest
 import yaml
 
-sys.path.append("src")
+sys.path.append("src")  # noqa: E402
 
-import charm  # noqa: E402
-import wordpress  # noqa: E402
+import charm
+import wordpress
 
 
 TEST_MODEL_CONFIG = {