← Back to team overview

wordpress-charmers team mailing list archive

Re: [Merge] ~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

 

Review: Approve

Seems fine, apart from being a shell script, which we have a general policy against because they grow and devour future travellers. Given it is calling plugin_handler.py, I even know there is an interpreter already on the image :) Not for this branch, but worth adding a task to convert this to Python on your trello or whatnot. Unless shell here is a docker requirement for some reason.
-- 
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/385456
Your team Wordpress Charmers is subscribed to branch ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.


References