wordpress-charmers team mailing list archive

[Tom Haddon <tom.haddon@xxxxxxxxxxxxx>]

Two small comments inline, otherwise looks good.

Diff comments:

> diff --git a/requirements.txt b/requirements.txt
> index 888e37a..addda44 100644
> --- a/requirements.txt
> +++ b/requirements.txt
> @@ -1,2 +1,3 @@
>  # Include python requirements here
>  requests
> +ops

This should be before requests for alpha sorting

> diff --git a/tox.ini b/tox.ini
> index 4f55f1b..fdaabc8 100644
> --- a/tox.ini
> +++ b/tox.ini
> @@ -19,7 +19,8 @@ commands =
>  deps = -r{toxinidir}/tests/unit/requirements.txt
>         -r{toxinidir}/requirements.txt
>  setenv =
> -  PYTHONPATH={toxinidir}/lib
> +#  PYTHONPATH={toxinidir}/lib

Do we still need this?

> +  PYTHONPATH={toxinidir}/src:{toxinidir}/build/lib:{toxinidir}/build/venv
>    TZ=UTC
>  
>  [testenv:integration]


-- 
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/393537
Your team Wordpress Charmers is requested to review the proposed merge of ~tcuthbert/charm-k8s-wordpress:update_charm into charm-k8s-wordpress:master.