wordpress-charmers team mailing list archive

[Haw Loeung <haw.loeung@xxxxxxxxxxxxx>]

Diff comments:

> diff --git a/Dockerfile b/Dockerfile
> index 0994203..1fe4cbd 100644
> --- a/Dockerfile
> +++ b/Dockerfile
> @@ -1,8 +1,10 @@
>  ARG DIST_RELEASE
> -
>  FROM ubuntu:${DIST_RELEASE}
> +ARG DIST_RELEASE

That's twice?

> +ARG VERSION
>  
>  LABEL maintainer="wordpress-charmers@xxxxxxxxxxxxxxxxxxx"
> +LABEL org.label-schema.version=${DIST_RELEASE}-${VERSION}
>  
>  # HTTPS_PROXY used when we RUN curl to download Wordpress itself
>  ARG BUILD_DATE


-- 
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/395044
Your team Wordpress Charmers is requested to review the proposed merge of ~tcuthbert/charm-k8s-wordpress:master into charm-k8s-wordpress:master.