wordpress-charmers team mailing list archive

[Stuart Bishop <stuart.bishop@xxxxxxxxxxxxx>]

Review: Approve

Looks good!

Diff comments:

> diff --git a/src/charm.py b/src/charm.py
> index edade47..1c2f1de 100755
> --- a/src/charm.py
> +++ b/src/charm.py
> @@ -146,7 +152,8 @@ class WordpressCharm(CharmBase):
>              msg = "Wordpress needs configuration"
>              logger.info(msg)
>              self.model.unit.status = MaintenanceStatus(msg)
> -            installed = self.wordpress.first_install(self.get_service_ip())
> +            initial_password = self._get_initial_password()

I'm guessing this code only runs on the leader, so no need to worry about getting an empty password from _get_initial_password()

> +            installed = self.wordpress.first_install(self.get_service_ip(), initial_password)
>              if not installed:
>                  msg = "Failed to configure wordpress"
>                  logger.info(msg)


-- 
https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/395982
Your team Wordpress Charmers is requested to review the proposed merge of ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:admin-password-action into charm-k8s-wordpress:master.