← Back to team overview

wordpress-charmers team mailing list archive

Re: [Merge] ~stub/charm-k8s-wordpress:ops-lib-mysql into charm-k8s-wordpress:master

 

Review: Approve

Looks good, with one comment about alphabetising requirements.txt.

Diff comments:

> diff --git a/requirements.txt b/requirements.txt
> index 875fb9a..52d0cf0 100644
> --- a/requirements.txt
> +++ b/requirements.txt
> @@ -1,3 +1,4 @@
>  # Include python requirements here
>  ops
>  requests
> +ops-lib-mysql

worth alphabetising?



-- 
https://code.launchpad.net/~stub/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/396227
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.


References