← Back to team overview

wordpress-charmers team mailing list archive

Thread
Date

Re: [Merge] ~sajoupa/charm-k8s-wordpress:modsecurity into charm-k8s-wordpress:master

To: Laurent Sesquès <laurent.sesques@xxxxxxxxxxxxx>
From: Tom Haddon <mp+414357@xxxxxxxxxxxxxxxxxx>
Date: Wed, 19 Jan 2022 17:57:51 -0000
In-reply-to: <164261204701.10965.12850373154289183039.launchpad@ackee.canonical.com>
Reply-to: mp+414357@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

Review: Approve

LGTM, but could you update the commit message to say you're optionally adding this module, since it requires the MODSEC build argument to be set?
-- 
https://code.launchpad.net/~sajoupa/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/414357
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.

References

[Merge] ~sajoupa/charm-k8s-wordpress:modsecurity into charm-k8s-wordpress:master
From: Laurent Sesquès, 2022-01-19