wordpress-charmers team mailing list archive

[Tom Haddon <mp+427199@xxxxxxxxxxxxxxxxxx>]

One question inline

Diff comments:

> diff --git a/src/charm.py b/src/charm.py
> index a7234e0..c8958f1 100755
> --- a/src/charm.py
> +++ b/src/charm.py
> @@ -242,6 +242,8 @@ class WordpressCharm(CharmBase):
>                  "ingressResources": [
>                      {
>                          "annotations": {
> +                            "nginx.ingress.kubernetes.io/proxy-redirect-from": "http://"; + self.model.config["blog_hostname"] + ":8000/",
> +                            "nginx.ingress.kubernetes.io/proxy-redirect-to": "https://"; + self.model.config["blog_hostname"] + "/",

Wouldn't this to be hard coding https redirect even if someone hasn't configured TLS?

>                              "nginx.ingress.kubernetes.io/proxy-body-size": "10m",
>                              "nginx.ingress.kubernetes.io/proxy-send-timeout": "300s",
>                          },


-- 
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/427199
Your team Wordpress Charmers is requested to review the proposed merge of ~tcuthbert/charm-k8s-wordpress:master into charm-k8s-wordpress:master.