xubuntu-dev team mailing list archive
-
xubuntu-dev team
-
Mailing list archive
-
Message #04806
Re: [Merge] lp:~xubuntu-dev/ubuntu-cdimage/bionic_image_size into lp:ubuntu-cdimage
Review: Needs Fixing
Would you care to fix up the issues identified inline?
Diff comments:
> === modified file 'lib/cdimage/tree.py'
> --- lib/cdimage/tree.py 2019-02-14 22:19:28 +0000
> +++ lib/cdimage/tree.py 2019-02-17 20:10:44 +0000
> @@ -978,7 +979,8 @@
> "However, you may still test it using a DVD, a larger USB "
> "drive, or a virtual machine.")
> elif (self.project in usb_projects or
> - (self.project == "xubuntu" and series >= "raring") or
> + (self.project == "xubuntu" and series >= "raring" and
> + series << "xenial") or
This is not the right syntax. We use the normal '<' operator, not the dpkg-style '<<'.
Also, reordering these cases would simplify the checks - check bionic first, if not newer than bionic, check xenial, if not newer than xenial, check raring.
> (self.project == "ubuntu-gnome" and series >= "saucy" and
> series << "xenial")):
> sentences.append(
--
https://code.launchpad.net/~xubuntu-dev/ubuntu-cdimage/bionic_image_size/+merge/363298
Your team Xubuntu Developers is subscribed to branch lp:~xubuntu-dev/ubuntu-cdimage/bionic_image_size.
References