xubuntu-dev team mailing list archive

[Steve Langasek <steve.langasek@xxxxxxxxxxxxx>]

Review: Needs Fixing



Diff comments:

> === modified file 'lib/cdimage/tree.py'
> --- lib/cdimage/tree.py	2019-02-14 22:19:28 +0000
> +++ lib/cdimage/tree.py	2019-02-18 03:39:05 +0000
> @@ -970,7 +970,8 @@
>          elif (self.project in ("ubuntu-gnome",
>                                 "kubuntu",
>                                 "ubuntu-mate",
> -                               "ubuntu-budgie") and series >= "xenial"):
> +                               "ubuntu-budgie",
> +                               "xubuntu") and series >= "xenial"):
>              sentences.append(
>                  "Warning: This image is oversized (which is a bug) and will "
>                  "not fit onto a 2GB USB stick.")

This causes xenial xubuntu images > 1GB to show a warning that they don't fit on a 2GB USB stick.  That doesn't sound like what you want, the limit and the warning message should match.



-- 
https://code.launchpad.net/~xubuntu-dev/ubuntu-cdimage/bionic_image_size/+merge/363298
Your team Xubuntu Developers is subscribed to branch lp:~xubuntu-dev/ubuntu-cdimage/bionic_image_size.