xubuntu-dev team mailing list archive

[Steve Dodd <1833863@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

XFCE & Xubuntu use <Merge type="all" /> in their menu files, which
python-xdg currently (all current versions) does not handle correctly:

https://gitlab.freedesktop.org/xdg/pyxdg/issues/12

I think the fix is as simple as

--- Menu.py.a   2019-06-23 17:44:24.992850139 +0100
+++ Menu.py.b   2019-06-23 17:44:41.052807584 +0100
@@ -997,7 +997,7 @@
                 for menuentry in menu.MenuEntries:
                     if menuentry not in tmp_e:
                         menu.Entries.append(menuentry)
-            elif order[1] == "menus" or order[1] == "all":
+            if order[1] == "menus" or order[1] == "all":
                 menu.Submenus.sort()
                 for submenu in menu.Submenus:
                     if submenu.Name not in tmp_s:

But as it can also be trivially worked around by replacing <Merge
type="all" /> with <Merge type="menus" /><Merge type="files" />, I
wonder if this should be done in XFCE/Xubuntu?

** Affects: pyxdg
     Importance: Unknown
         Status: Unknown

** Affects: garcon (Ubuntu)
     Importance: Undecided
         Status: New

** Affects: pyxdg (Ubuntu)
     Importance: Undecided
         Status: New

** Affects: xubuntu-default-settings (Ubuntu)
     Importance: Undecided
         Status: New

** Also affects: garcon (Ubuntu)
   Importance: Undecided
       Status: New

** Also affects: xubuntu-default-settings (Ubuntu)
   Importance: Undecided
       Status: New

** Bug watch added: gitlab.freedesktop.org/xdg/pyxdg/issues #12
   https://gitlab.freedesktop.org/xdg/pyxdg/issues/12

** Also affects: pyxdg via
   https://gitlab.freedesktop.org/xdg/pyxdg/issues/12
   Importance: Unknown
       Status: Unknown

-- 
You received this bug notification because you are a member of Xubuntu
Developers, which is subscribed to xubuntu-default-settings in Ubuntu.
Matching subscriptions: xubuntu-default-settings
https://bugs.launchpad.net/bugs/1833863

Title:
  Incorrect logic for <Merge type="all">

To manage notifications about this bug go to:
https://bugs.launchpad.net/pyxdg/+bug/1833863/+subscriptions