← Back to team overview

yade-dev team mailing list archive

Re: [Branch ~yade-dev/yade/trunk] Rev 2079: Previous commit correction. Thanks to Vaclav.

 

Hi Vaclav, thanks for suggestion, it seems, I have fixed it.

When I ran some tests with old variant and a new one (with null-vector
checks), I got a little bit different results with regular-hexa. Does it
mean, that in some cases geometry was wrongly calculated previously?


2010/3/15 <noreply@xxxxxxxxxxxxx>

> ------------------------------------------------------------
> revno: 2079
> committer: Anton Gladky <gladky.anton@xxxxxxxxx>
> branch nick: trunk
> timestamp: Mon 2010-03-15 12:24:35 +0100
> message:
>  Previous commit correction. Thanks to Vaclav.
> modified:
>  pkg/dem/DataClass/InteractionGeometry/Dem3DofGeom_SphereSphere.cpp
>
>
> --
> lp:yade
> https://code.launchpad.net/~yade-dev/yade/trunk<https://code.launchpad.net/%7Eyade-dev/yade/trunk>
>
> Your team Yade developers is subscribed to branch lp:yade.
> To unsubscribe from this branch go to
> https://code.launchpad.net/~yade-dev/yade/trunk/+edit-subscription<https://code.launchpad.net/%7Eyade-dev/yade/trunk/+edit-subscription>
> .
>
> === modified file
> 'pkg/dem/DataClass/InteractionGeometry/Dem3DofGeom_SphereSphere.cpp'
> --- pkg/dem/DataClass/InteractionGeometry/Dem3DofGeom_SphereSphere.cpp
>  2010-03-12 21:20:32 +0000
> +++ pkg/dem/DataClass/InteractionGeometry/Dem3DofGeom_SphereSphere.cpp
>  2010-03-15 11:24:35 +0000
> @@ -45,9 +45,10 @@
>                Vector3r axis=planeNormal.Cross(planePt); axis.Normalize();
>                Real angle=planePt.Length()/radius;
>                normal2pt.FromAxisAngle(axis,angle);
> +               Quaternionr ret; return
> ret.Align(Vector3r::UNIT_X,normal2pt*planeNormal);
> +       } else {
> +               return Quaternionr::IDENTITY;
>        }
> -       Quaternionr ret; ret.Align(Vector3r::UNIT_X,normal2pt*planeNormal);
> -       return ret;
>  }
>
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~yade-dev<https://launchpad.net/%7Eyade-dev>
> Post to     : yade-dev@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~yade-dev<https://launchpad.net/%7Eyade-dev>
> More help   : https://help.launchpad.net/ListHelp
>
>

Follow ups

References