yade-dev team mailing list archive

[Bruno Chareyre <bruno.chareyre@xxxxxxxxxxx>]

Hi Luc (Sc),

I had a look at CohesiveFrictionalPM while renaming and fixing stuff.
It seems you just copied CohesiveFrictionalContactLaw and changed a few 
lines. Can't it be all include in the same class? What is the difference?
It would be better to avoid this when possible. Currently, we have 
CundallStrack which is a copy of ElasticContactLaw by Boon, CFPM a copy 
of CFCL by yourself, not mentionning a few others.
This practice is duplicating the potential problems from existing code 
to new classes, and makes them even harder to fix when they are spreaded 
everywhere (I just fixed potential problems in CFCL, but I didn't fix 
them in CFPM). It also result in naming conflicts : how to reflect the 
difference between a CF "contactLaw" and a CF "particleModel"?
Bruno



--
_______________
Bruno Chareyre
Associate Professor
Grenoble INP
Lab. 3SR
BP 53 - 38041, Grenoble cedex 9 - France
Tél : 33 4 56 52 86 21
Fax : 33 4 76 82 70 43
________________