← Back to team overview

yade-dev team mailing list archive

Re: [Branch ~yade-dev/yade/trunk] Rev 2344: - miniEigen : memory leak source suspected (FIXME added)

 

> +//FIXME : risk of memory leak with these "new"?
>  static Quaternionr* Quaternionr_fromAxisAngle(const Vector3r& axis, const Real angle){ return new Quaternionr(AngleAxisr(angle,axis)); }
>  static Quaternionr* Quaternionr_fromAngleAxis(const Real angle, const Vector3r& axis){ return new Quaternionr(AngleAxisr(angle,axis)); }

Bruno, what is the use of this?? Of course it will leak memory!!

> +def chCylinder(begin=Vector3(0,0,0),end=Vector3(1.,0.,0.),radius=0.2,dynamic=True,wire=False,color=None,highlight=False,material=-1,mask=1):

I renamed that to chainedCylinder. Please do not specify default values
for begin, end and radius -- utils.{sphere,facet,...} don't do it
either, it is meaningless. Without defaults, the user is required to
specify one himself/herself by python syntax, rather than getting an
unexpected thing.

> This shape is the Minkowsky sum of line and sphere.

FYI MinkowskI (I changed that at a few places, but not everywhere)





Follow ups

References