← Back to team overview

yade-dev team mailing list archive

Re: [Branch ~yade-dev/yade/trunk] Rev 2741: 1. LOG_INFO and LOG_WARN are disabled when log4cxx feature is disabled.

 

>>    1. LOG_INFO and LOG_WARN are disabled when log4cxx feature is
>> disabled.
> Anton, I would prefer if you keep those enabled. Or at least eplain
> why the log message you mentioned elsewhere makes you so unhappy?

In buildbot logs, INFOs were cluttering some outputs (compare
https://yade-dem.org/buildbot/builders/yade-full/builds/362/steps/test_1/logs/stdio
vs.
https://yade-dem.org/buildbot/builders/yade-full/builds/358/steps/test_1/logs/stdio).
In some cases, getting all LOG_INFOs with disabled log4cxx could even
slow down simulations if there is too much output.

The only solution would be to turn all LOG_INFOs into LOG_DEBUGs or
remove them, I was about to do that in Triaxial engines. It severely
decreases the logging capabilities though.

I'd suggest to keep LOG_WARN's enabled (nobody reported problems with
them), but disable LOG_INFO's.
That way, programmers would have more choice:
- LOG_DEBUG: disabled in optimized builds _or_ without log4cxx (1).
- LOG_INFO: not disabled in optimized builds+log4cxx _but_ disabled
without log4cxx. (2)
- LOG_WARN: worth reporting even when log4cxx is disabled. (3)

Currently, (1) and (3) are possible, but not (2).

Bruno

p.s. If the behaviour is modified in the end, it will have to be
reflected here: https://yade-dem.org/doc/prog.html#logging





References