← Back to team overview

yade-dev team mailing list archive

Re: [Bug 729079] Re: Performance optimization of InsertionSortCollider

 

Why do you think it should it break the algorithm?
It is because "interactions->insert(newI)" could insert two interactions
in the same list from different threads?
It must be very rare since interactions are stored in bodies: maybe it
explains why tests are passed (just luck).
Let's be super-carefull with this, but if there is a possible
improvement let's not neglect it.

Bruno

On 19/03/11 13:02, Anton Gladky wrote:
> I have such doubts, need to check.
> But both --check and --test are passed.
>
> Anton
>
>
>
>
> On Sat, Mar 19, 2011 at 12:11 PM, Sergei D. <sj2001@xxxxxxxxx> wrote:
>> Are you shure? Such parallelization will break insertion sort algorithm.
>>
>> --
>>
>> --
>> Best regards,
>> Sergei D.
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~yade-dev
>> Post to     : yade-dev@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~yade-dev
>> More help   : https://help.launchpad.net/ListHelp
>>
> _______________________________________________
> Mailing list: https://launchpad.net/~yade-dev
> Post to     : yade-dev@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~yade-dev
> More help   : https://help.launchpad.net/ListHelp
>


-- 
_______________
Bruno Chareyre
Associate Professor
ENSE³ - Grenoble INP
Lab. 3SR
BP 53 - 38041, Grenoble cedex 9 - France
Tél : +33 4 56 52 86 21
Fax : +33 4 76 82 70 43
________________




Follow ups

References