yade-dev team mailing list archive

[Bruno Chareyre <bruno.chareyre@xxxxxxxxxxx>]

I don't see anything wrong. It sounds correct.

B

On 20/07/11 14:52, Anton Gladky wrote:
> Sergei, Bruno and other competence people. Please, have a better look
> at this commit.
> One of my simulations was aborted with the following message:
> "Exception occured:
> InteractionContainer::erase: attempt to delete non-existent
> interaction ##14778+16689"
>
> I think, it happened because in id2 was not checked on existence (only id1).
> I added this id2 check.
>
> Also I relaxed "throw std::logic_error" till "LOG_ERROR" not to break
> the simulation.
> Code review is welcome.
>
> Thanks
> Anton
>
> On Wed, Jul 20, 2011 at 2:44 PM,  <noreply@xxxxxxxxxxxxx> wrote:
>> ------------------------------------------------------------
>> revno: 2893
>> committer: Anton Gladky <gladky.anton@xxxxxxxxx>
>> branch nick: yade
>> timestamp: Wed 2011-07-20 14:42:36 +0200
>> message:
>>  Fix (hopefully) simulation abort, when an interaction::erase is trying to delete an interaction, where one of bodies is already removed from simulation (id2)
>> modified:
>>  core/InteractionContainer.cpp
>>  core/InteractionContainer.hpp


-- 
_______________
Bruno Chareyre
Associate Professor
ENSE³ - Grenoble INP
Lab. 3SR
BP 53 - 38041, Grenoble cedex 9 - France
Tél : +33 4 56 52 86 21
Fax : +33 4 76 82 70 43
________________