Thread Previous • Date Previous • Date Next • Thread Next |
BTW the uploaded code is not working, I will try to fix it.What does that mean? If somebody is using the capillary law, will he get the same results as usual? I hope you make sure that you don't break what already works before comitting something.
Everything works fine now. I did a mistake and repaired (undo changes from commit before) it in the last commit. Results are the same as before, but now without memory leak and working isBroken flag ;)
We probably need a regression test on this law actually.What means if ((*ii)->isReal()) { ??? What is a "real" contact?Yade [2]: i.isReal? Docstring: True if this interaction has both geom and phys; False otherwise.
Ok, I thought real contact is a contact with penetrationDepth > 0, thats why I did the mistake in the code...
Cheers BrunoCheers, Christian Zitat von Bruno Chareyre <bruno.chareyre@xxxxxxxxxxx>:Hi Christian, Please, be a bit more explicit in the logs, this is the only way for us all to know what happens in Yade without diving into the code. If you type "git push" (without the -m) it pops up an editor where you can type plain text. Don't hesitate to type detailed descriptions there. Cheers. Bruno On 08/05/12 08:00, Christian Jakob wrote:Branch: refs/heads/master Home: https://github.com/yade/trunk Commit: 1bea7e3c3c229468a3a5d208e79b71ef4b9d9107 https://github.com/yade/trunk/commit/1bea7e3c3c229468a3a5d208e79b71ef4b9d9107 Author: Christian Jakob <jakob@xxxxxxxxxxxxxxxxxxx> Date: 2012-05-07 (Mon, 07 May 2012) Changed paths: M pkg/dem/Law2_ScGeom_CapillaryPhys_Capillarity.cpp Log Message: ----------- improvements in Law2_ScGeom_CapillaryPhys_Capillarity _______________________________________________ Mailing list: https://launchpad.net/~yade-dev Post to : yade-dev@xxxxxxxxxxxxxxxxxxx Unsubscribe : https://launchpad.net/~yade-dev More help : https://help.launchpad.net/ListHelp-- _______________ Bruno Chareyre Associate Professor ENSE³ - Grenoble INP 11, rue des Mathématiques BP 46 38402 St Martin d'Hères, France Tél : +33 4 56 52 86 21 Fax : +33 4 76 82 70 43 _______________________________________________________________ Mailing list: https://launchpad.net/~yade-dev Post to : yade-dev@xxxxxxxxxxxxxxxxxxx Unsubscribe : https://launchpad.net/~yade-dev More help : https://help.launchpad.net/ListHelp-- _______________ Bruno Chareyre Associate Professor ENSE³ - Grenoble INP 11, rue des Mathématiques BP 46 38402 St Martin d'Hères, France Tél : +33 4 56 52 86 21 Fax : +33 4 76 82 70 43 ________________ _______________________________________________ Mailing list: https://launchpad.net/~yade-dev Post to : yade-dev@xxxxxxxxxxxxxxxxxxx Unsubscribe : https://launchpad.net/~yade-dev More help : https://help.launchpad.net/ListHelp
Thread Previous • Date Previous • Date Next • Thread Next |