← Back to team overview

yade-dev team mailing list archive

Re: Problem with Re: [Branch ~yade-pkg/yade/git-trunk] Rev 3757: Change in the calculation of the normal and tangential stiffness and damping.

 

> Raphael, there is something wrong with this commit.
> Check-tests are failing. Please, have a look.

Regression tests can be tested with the following commands [1]:
yade --test
yade --check

If they don't give exactly the same as before it is reported as a failure.
In your case the behavior is really supposed to change though. So it is
maybe the target value of the a regression test itself that must be changed.

Otherwise good commit. You avoided the merge problem and typed a good
comment (you can make comments shorter, very detailed explanations can
go into the documentation if needed since the average user will never
look for explanations in the commit logs). Thanks.

Bruno

[1] https://yade-dem.org/doc/prog.html?highlight=regression#check-tests


Follow ups

References