← Back to team overview

yade-dev team mailing list archive

[Bug 1261388] Re: Wrong code comment

 

** Changed in: yade
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yade
developers, which is subscribed to Yade.
https://bugs.launchpad.net/bugs/1261388

Title:
  Wrong code comment

Status in Yet Another Dynamic Engine:
  Fix Released

Bug description:
  Hi,

  I think there is a mistake into the code comment : Ip2_FrictMat_FrictMat_FrictPhys.cpp line 40.
  According the the documentation [https://yade-dem.org/doc/formulation.html#normal-stiffness] and the code, it seems that this Ip2 uses :

  Li = 2 * Ri           (i is a sphere)

  as a typical length to transform Young modulus into stiffness :

  Ki = Li * Ei = 2 * Ri * Ei

  But into the code comment (L40), it's written : "(Ri.Ei/2) is the
  stiffness of a contact point on sphere "i", and to my mind it should
  be "(Ri.Ei*2) ..."

  Don't you think so ?

To manage notifications about this bug go to:
https://bugs.launchpad.net/yade/+bug/1261388/+subscriptions


References