← Back to team overview

yade-dev team mailing list archive

[Branch ~yade-pkg/yade/git-trunk] Rev 4011: Recommend minimal Eigen3 version 3.2.1.

 

------------------------------------------------------------
revno: 4011
committer: Anton Gladky <gladky.anton@xxxxxxxxx>
timestamp: Mon 2014-06-09 14:35:37 +0200
message:
  Recommend minimal Eigen3 version 3.2.1.
  
  Older Eigen3 versions can lead to instabilities
  due to enabled vectorization.
modified:
  CMakeLists.txt
  doc/sphinx/installation.rst


--
lp:yade
https://code.launchpad.net/~yade-pkg/yade/git-trunk

Your team Yade developers is subscribed to branch lp:yade.
To unsubscribe from this branch go to https://code.launchpad.net/~yade-pkg/yade/git-trunk/+edit-subscription
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt	2014-05-30 11:58:01 +0000
+++ CMakeLists.txt	2014-06-09 12:35:37 +0000
@@ -130,7 +130,13 @@
 # Use Eigen3 by default
 IF (EIGEN3_FOUND)
   INCLUDE_DIRECTORIES(${EIGEN3_INCLUDE_DIR})
-  MESSAGE(STATUS "Found Eigen3")
+  MESSAGE(STATUS "Found Eigen3, version: ${EIGEN3_VERSION}")
+  
+  # Minimal recommended version 3.2.1
+  IF ((${EIGEN3_MAJOR_VERSION} LESS 2) OR ((${EIGEN3_MAJOR_VERSION} EQUAL 2) AND (${EIGEN3_MINOR_VERSION} LESS 1)))
+    MESSAGE(WARNING "Minimal recommended Eigen3 version is 3.2.1")
+  ENDIF ((${EIGEN3_MAJOR_VERSION} LESS 2) OR ((${EIGEN3_MAJOR_VERSION} EQUAL 2) AND (${EIGEN3_MINOR_VERSION} LESS 1)))
+
   SET(CONFIGURED_FEATS "${CONFIGURED_FEATS} Eigen3")
 ENDIF(EIGEN3_FOUND)
 #===========================================================

=== modified file 'doc/sphinx/installation.rst'
--- doc/sphinx/installation.rst	2014-05-14 12:31:59 +0000
+++ doc/sphinx/installation.rst	2014-06-09 12:35:37 +0000
@@ -1,4 +1,4 @@
-###############
+"###############
 Installation
 ###############
 
@@ -115,7 +115,7 @@
 * `libQGLViewer <http://www.libqglviewer.com>`_
 * `python <http://www.python.org>`_, `numpy <http://numpy.scipy.org>`_, `ipython <http://ipython.scipy.org>`_
 * `matplotlib <http://matplotlib.sf.net>`_
-* `eigen3 <http://eigen.tuxfamily.org>`_ algebra library
+* `eigen3 <http://eigen.tuxfamily.org>`_ algebra library (minimal recommended version 3.2.1)
 * `gdb <http://www.gnu.org/software/gdb>`_ debugger
 * `sqlite3 <http://www.sqlite.org>`_ database engine
 * `Loki <http://loki-lib.sf.net>`_ library