yade-dev team mailing list archive

[Bruno Chareyre <bruno.chareyre@xxxxxxxxxxx>]

Thanks Jerome, it was the good way to proceed I think. I have a few
comments/suggestions:
1- Please don't use french names for variables, even in the c++ code
(valPropres).
2- We should now remame REC_STRESS -> REC_CSTRESS, no?
3- it seems the most used data (matrix in x,y,z) is still not available,
isn't it possible to include it also the output in the form of a matrix
(maybe with a separate flag are all together if BSTRESS)?
4- You can output eigen values and directions in the form of vector3 +
matrix, it would save a lot of lines of code, then in paraview you can
always select individual components.
5- For braces, we tend to use this when possible:

section {
    bla;}

instead of

section
{
    bla;
}

Combining 3 and 4, your 65 lines (466-530) could fit in maybe 10 lines,
which will be a lot easier to browse and read.

Bruno




On 16/07/14 13:47, Jérôme Duriez wrote:
> Question #251712 on Yade changed:
> https://answers.launchpad.net/yade/+question/251712
>
> Jérôme Duriez posted a new comment:
> Hi,
>
> See
> https://github.com/yade/trunk/commit/939e3d771bd6978da2bb16833a535eebd4eb6043
> for this commit.
>
> It includes a new recorder (yet another one..) in VTKRecorder:
> "bstresses" to generate scalar data for principal stresses, and
> arraydata for principal directions, in "sphere...s" VTK files. See the
> doc.
>
> Tell me if something is wrong...
>


-- 
_______________
Bruno Chareyre
Associate Professor
ENSE³ - Grenoble INP
Lab. 3SR
BP 53
38041 Grenoble cedex 9
Tél : +33 4 56 52 86 21
Fax : +33 4 76 82 70 43
________________