yade-dev team mailing list archive

[noreply@xxxxxxxxxxxxx]

------------------------------------------------------------
revno: 4149
committer: Anton Gladky <gladky.anton@xxxxxxxxx>
timestamp: Mon 2014-08-25 18:21:43 +0200
message:
  Fix cs calculation in ViscoelasticPM
  
  It seems to be an error in [Pournin2001] (22) Eq.4, missing factor 2
  Thanks to Dominik Boemer for pointing this out
  http://www.mail-archive.com/yade-users@xxxxxxxxxxxxxxxxxxx/msg08741.html
modified:
  pkg/dem/ViscoelasticPM.cpp


--
lp:yade
https://code.launchpad.net/~yade-pkg/yade/git-trunk

Your team Yade developers is subscribed to branch lp:yade.
To unsubscribe from this branch go to https://code.launchpad.net/~yade-pkg/yade/git-trunk/+edit-subscription

=== modified file 'pkg/dem/ViscoelasticPM.cpp'
--- pkg/dem/ViscoelasticPM.cpp	2014-08-25 15:42:17 +0000
+++ pkg/dem/ViscoelasticPM.cpp	2014-08-25 16:21:43 +0000
@@ -192,8 +192,12 @@
 		kn1 = kn2 = 1/Tc/Tc * ( Mathr::PI*Mathr::PI + pow(log(En),2) )*massR;
 		cn1 = cn2 = -2.0 /Tc * log(En)*massR;
 		ks1 = ks2 = 2.0/7.0 /Tc/Tc * ( Mathr::PI*Mathr::PI + pow(log(Et),2) )*massR;
-		cs1 = cs2 = -2.0/7.0 /Tc * log(Et)*massR;
-	
+		
+		// It seems to be an error in [Pournin2001] (22) Eq.4, missing factor 2
+		// Thanks to Dominik Boemer for pointing this out
+		// http://www.mail-archive.com/yade-users@xxxxxxxxxxxxxxxxxxx/msg08741.html
+		cs1 = cs2 = -4.0/7.0 /Tc * log(Et)*massR;
+		
 		if (std::abs(cn1) <= Mathr::ZERO_TOLERANCE ) cn1=0;
 		if (std::abs(cn2) <= Mathr::ZERO_TOLERANCE ) cn2=0;
 		if (std::abs(cs1) <= Mathr::ZERO_TOLERANCE ) cs1=0;