yade-dev team mailing list archive

[Bruno Chareyre <bruno.chareyre@xxxxxxxxxxxxxxx>]

Hi Jerôme
It is really not critical but the logic of this implementation is weird.

calculate volumeNonPeri
if (volume) don't use the calculated value

This would make more sense:
if (!volume) calculate volumeNonPeri

Bruno


On 14/10/14 21:13, noreply@xxxxxxxxxxxxx wrote:
> ------------------------------------------------------------
> revno: 3471
> committer: jduriez <jerome.duriez@xxxxxxxxxxx>
> timestamp: Tue 2014-10-14 11:28:52 -0600
> message:
>   getStress() considers now an adequate volume value for non-periodic case (values passed as parameters may still also be taken into account)
> modified:
>   pkg/dem/Shop_02.cpp
>   py/_utils.cpp
>
>
> --
> lp:yade
> https://code.launchpad.net/~yade-pkg/yade/git-trunk
>
> Your team Yade developers is subscribed to branch lp:yade.
> To unsubscribe from this branch go to https://code.launchpad.net/~yade-pkg/yade/git-trunk/+edit-subscription
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~yade-dev
> Post to     : yade-dev@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~yade-dev
> More help   : https://help.launchpad.net/ListHelp


-- 
_______________
Bruno Chareyre
Associate Professor
ENSE³ - Grenoble INP
Lab. 3SR
BP 53
38041 Grenoble cedex 9
Tél : +33 4 56 52 86 21
Fax : +33 4 76 82 70 43
________________