← Back to team overview

yade-dev team mailing list archive

[Bug 1440887] Re: Buggy data in capillary files

 

Yes, the interpolation algorithm does require it.
See https://github.com/yade/trunk/blob/master/pkg/dem/Law2_ScGeom_CapillaryPhys_Capillarity.hpp#L108 and all "full_data[XX].D" in the cpp.
I should be able to manage it, thank you !

-- 
You received this bug notification because you are a member of Yade
developers, which is subscribed to Yade.
https://bugs.launchpad.net/bugs/1440887

Title:
  Buggy data in capillary files

Status in Yade:
  Fix Released

Bug description:
  Hi,

  ***** CURRENT SITUATION ******
  Current capillary files include some buggy data for dimensionless menisci volume (vol*), and filling angle delta2. Several examples are detailled in "prob.txt" attachment.

   Basically, on some lines, vol* and delta2 are discontinuous compared to adjacent lines. The discontinuous values are sometimes obviously wrong, with e.g. one vol* = 400 line 9704 of M(r=2). You may imagine the consequences on the construction of a soil-water characteristic curve...
  *******************************

  
  ****** HISTORY (explaining the current situation ?) ******
  Historically, these files come from a very first version of capillary files, that have been corrected twice. A first ("major") correction modified the volume values that were affected by a mistake during files construction (*). There has been a second ("minor") correction regarding the first lines of some files (**). Probably the discontinuous volume values existing now have been introduced during the major correction (*).
  ******************************************************

  
  ****** CORRECTION PROPOSAL ********
  After discussion with Luc Scholtes, some work has been done to correct the buggy volume / delta2 values that exist now. It has been decided to start from the very first version of the files. In this very first version no discontinuous volume values existed.
   
  But, discontinuous values of delta2, sometimes reaching - 6000 degrees have been now spotted in these very first files.
  To correct this, the lines including such discontinuous delta2 values have been simply erased. To do so, continuity has been checked with adjacent lines, spotting then errors like delta2 = - 6000 deg between delta2 = 55 and 54 degrees, and also delta2 = 3 degrees between 22 and 22.
  Doing so, roughly less than 1% of lines have been erased.

  Discontinuous lines being erased, volume values have been corrected towards the same direction than during correction (*).
  **************************************

  
  ****** FINAL SITUATION AFTER POSSIBLE APPROVAL OF PROPOSED CORRECTION*******
  This work has been completed. It is not uploaded yet, time being given for people to check the current situation, and possible discussion about the correction proposal.

  In the brand new files (only in my PC as for now), there should be no discontinuous values of vol* and delta2 anymore, and volume meniscii should be correct.
  ***********************************************************************************

  (*) https://answers.launchpad.net/yade/+question/201608
  (**) http://www.mail-archive.com/yade-dev%40lists.launchpad.net/msg10638.html

To manage notifications about this bug go to:
https://bugs.launchpad.net/yade/+bug/1440887/+subscriptions


References