← Back to team overview

yade-dev team mailing list archive

Re: [Branch ~yade-pkg/yade/git-trunk] Rev 3806: better handling of double contacts, get gid of function ScGem goOneWay

 

Hi Bruno,

actually, we have been using this just committed version of the code for quite 
a while as we found as well that there was a problem with GridConnection-
PFacet interactions. The tests we did for the paper did mainly include sphere-
grid and sphere-pfacet interactions. Our examples should not be affected but I 
will ask Anna to re-run the tests.

I know that the fix is probably not the nicest one as there is a lot of 
duplicated code but it fixes the seg fault issue for GridConnection-PFacet 
interactions and avoids some other issues with duplicated contacts with 
PFacets.

We will add some check-scripts.

Cheers
Klaus

On Thu, 10 Mar 2016 04:23:35 PM Bruno Chareyre wrote:
> Hi Klaus,
> I see many new lines just to fix one bug. Could you explain a bit?
> Would you have a couple scripts to suggest (our paper has good
> benchmarks tests) that we could include in check-scripts to be sure the
> main things don't get silently broken?
> Bruno
> 
> On 10/03/16 14:30, noreply@xxxxxxxxxxxxx wrote:
> > ------------------------------------------------------------
> > revno: 3806
> > committer: Klaus Thoeni <klaus.thoeni@xxxxxxxxx>
> > timestamp: Thu 2016-03-10 21:35:34 +1100
> > 
> > message:
> >   better handling of double contacts, get gid of function ScGem goOneWay
> > 
> > modified:
> >   pkg/common/PFacet.cpp
> >   pkg/common/PFacet.hpp
> > 
> > --
> > lp:yade
> > https://code.launchpad.net/~yade-pkg/yade/git-trunk
> > 
> > Your team Yade developers is subscribed to branch lp:yade.
> > To unsubscribe from this branch go to
> > https://code.launchpad.net/~yade-pkg/yade/git-trunk/+edit-subscription
> > 
> > 
> > _______________________________________________
> > Mailing list: https://launchpad.net/~yade-dev
> > Post to     : yade-dev@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~yade-dev
> > More help   : https://help.launchpad.net/ListHelp



References