yade-dev team mailing list archive

[Bruno Chareyre <bruno.chareyre@xxxxxxxxxxxxxxx>]

Hi Boon,
Thank you for progress report!

On 16/03/16 16:37, Chia Weng Boon wrote:
> I have also changed some of the existing files to make it compatible with
> my old files.  Please update and modify it accordingly if you think there
> is a better way to do it.
> ScGeom:  I took away the twist update because for polygons this is not used
> in Cundall's paper.  Please modify accordingly if there is some theoretical
> discovery.
Does it mean that the twist will be also disabled if someone has, let's
say, a sphere-sphere contact?
And did you find a reason why the twist should be defined differently
(or even undefined) in the case of polygons?
In general Yade is not meant to reproduce Cundall's equations on every
aspect.

> Clump:  The Update Properties looked different from the old one, and I had
> problems with clumps earlier on when updating the code.  Not sure if this
> is the problem, but i used the old one anyway.
We must make sure that adding some code does not imply regressions as
side effects.
Do you have any clue why the polyhedra code needs an older version of
updateProperties? What sort of problem do you find?
Rolling back such a function is most likely breaking, or at least
changing the behavior, of other parts of the code.

> YadeWrapper:  Added deleteClumpMembers function, since it was in my old
> version.
Is Clump::del not doing the same thing? Do you need such a function?

As far as I understand, you are half-way to a compatible code overall.
It will be really compatible when no changes will be required in other
files.
If somene else will do the remaining work, it would be helpful to him to
have more detailed explanations of why you had to roll back some changes
(which really means something to fix in your code, not something to roll
back in trunk).

Cheers

Bruno