yade-dev team mailing list archive
-
yade-dev team
-
Mailing list archive
-
Message #12673
Dynamic bodies and getSpheresVolume()
-
To:
yade-dev <yade-dev@xxxxxxxxxxxxxxxxxxx>
-
From:
Jerome Duriez <Jerome.Duriez@xxxxxxxxxxx>
-
Date:
Fri, 20 May 2016 21:30:04 +0000
-
Accept-language:
en-CA, en-US
-
Authentication-results:
spf=pass (sender IP is 136.159.160.216) smtp.mailfrom=ucalgary.ca; lists.launchpad.net; dkim=none (message not signed) header.d=none;lists.launchpad.net; dmarc=pass action=none header.from=ucalgary.ca;
-
Spamdiagnosticmetadata:
NSPM
-
Spamdiagnosticoutput:
1:23
-
Thread-index:
AdGy3oyZY9KcV9sgRVG4CjGmroMnxg==
-
Thread-topic:
Dynamic bodies and getSpheresVolume()
Hi,
getSpheresVolume() currently skips all dynamic bodies before even considering whether they are spheres or not [*]. I think it would you make sense to just consider the shape, and to remove this "dynamic" condition.
It would for instance allow to use consistently porosity() function for a fixed packing of sphere. (Now, porosity() then always returns 1 in such case)
What do you think ?
Jerome
[*] https://github.com/yade/trunk/blob/6d4a0d1689c6bad2dbdd6e27d1653418f7fc6498/pkg/dem/Shop_01.cpp#L308
PS: the same applies for other functions, such as getSpheresMass(), but this has not been an issue for me...
Follow ups