← Back to team overview

yade-dev team mailing list archive

Re: [Bug 1474956] Re: Clump::updateProperties discretization not defined robustly

 

Sounds like a good fix to me.

Klaus

On Tue, May 22, 2018 at 7:11 AM, Bruno Chareyre <1474956@xxxxxxxxxxxxxxxxxx>
wrote:

> ** Changed in: yade
>    Importance: Medium => Wishlist
>
> --
> You received this bug notification because you are a member of Yade
> developers, which is subscribed to Yade.
> https://bugs.launchpad.net/bugs/1474956
>
> Title:
>   Clump::updateProperties discretization not defined robustly
>
> Status in Yade:
>   Confirmed
>
> Bug description:
>   Most likely the reason for performance drop reported in [1]
>
>   dx in the voxel decomposition is minRad/discretization.
>   The problem is when a sphere of radius 1 is member of a clump which aabb
> has the size 1000 (for instance).
>   Using the minimal discretization=1 gives a number of voxel = 1e9 in such
> case and it is no possible to go below this number.
>   I think discretization should refer to aabb size, not member size. I
> have this fixed locally, let me know if you agree with the fix.
>
>   [1] https://answers.launchpad.net/yade/+question/268954
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/yade/+bug/1474956/+subscriptions
>
> _______________________________________________
> Mailing list: https://launchpad.net/~yade-dev
> Post to     : yade-dev@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~yade-dev
> More help   : https://help.launchpad.net/ListHelp
>

-- 
You received this bug notification because you are a member of Yade
developers, which is subscribed to Yade.
https://bugs.launchpad.net/bugs/1474956

Title:
  Clump::updateProperties discretization not defined robustly

Status in Yade:
  Confirmed

Bug description:
  Most likely the reason for performance drop reported in [1]

  dx in the voxel decomposition is minRad/discretization.
  The problem is when a sphere of radius 1 is member of a clump which aabb has the size 1000 (for instance).
  Using the minimal discretization=1 gives a number of voxel = 1e9 in such case and it is no possible to go below this number.
  I think discretization should refer to aabb size, not member size. I have this fixed locally, let me know if you agree with the fix.

  [1] https://answers.launchpad.net/yade/+question/268954

To manage notifications about this bug go to:
https://bugs.launchpad.net/yade/+bug/1474956/+subscriptions


References