yade-dev team mailing list archive

[Jerome Duriez <jerome.duriez@xxxxxxxxx>]

Hi,

What is the reason for having (for instance) Shop__getPorosity() in 
py/_utils.hpp/cpp and Shop::getPorosity() in pkg/dem/Shop.hpp / 
Shop_01.cpp ?

I can see the latter has "scene" as an argument [1] in addition to 
"volume" (contrary to the former [2]), but probably this could be 
removed from the definition, always using Omega::instance().getScene() 
in the implementation [3] ? So, I'm not sure this is the reason

Is this for Python wrapping ? Could we not use Shop::getPorosity (once 
we removed the scene argument) at 
https://github.com/yade/trunk/blob/master/py/_utils.cpp#L463 ?


The same question goes for many other functions, I guess, and the 
general philosophy behind having py/_utils.*pp in addition to pkg/dem/Shop*

Thank you,

Jérôme


[1] https://github.com/yade/trunk/blob/master/pkg/dem/Shop.hpp#L56
[2] https://github.com/yade/trunk/blob/master/py/_utils.hpp#L123
[3] just modifying 
https://github.com/yade/trunk/blob/master/pkg/dem/Shop_01.cpp#L300

------
Chargé de Recherche / Research Associate
Irstea, RECOVER
3275 route de Cezanne – CS 40061 13182 Aix-en-Provence Cedex 5 FRANCE
+33 (0)4 42 66 99 21