yade-dev team mailing list archive

[Robert Caulk <1804621@xxxxxxxxxxxxxxxxxx>]

It seems the only option is to go through and fix these functions
manually. Let's just make sure we find everything that needs to be fixed
before committing the fix. Can you verify the list below and also look
through the trunk to see if there are any other unintended effects?

Looking through trunk/utils.py it seems the following functions need to be fixed:
uniaxialTestFeatures()[1]
aabbDim() [2]
plotNumInteractions() [3] 
plotDirections() [4]
avgNumInteractions() [7]

Meanwhile, the flexibility of the python language means that the following functions should work before and after the change, right? :
fractionalBox()[5] 
perpindicularArea()[6]

Cheers,

Robert

[*]https://bugs.launchpad.net/yade/+bug/1764424
[1]https://github.com/yade/trunk/blob/720a352989c9b1148cf04022d14ec3da233fe563/py/utils.py#L558
[2]https://github.com/yade/trunk/blob/720a352989c9b1148cf04022d14ec3da233fe563/py/utils.py#L379
[4]https://github.com/yade/trunk/blob/720a352989c9b1148cf04022d14ec3da233fe563/py/utils.py#L448
[3]https://github.com/yade/trunk/blob/720a352989c9b1148cf04022d14ec3da233fe563/py/utils.py#L459
[5]https://github.com/yade/trunk/blob/720a352989c9b1148cf04022d14ec3da233fe563/py/utils.py#L402
[6]https://github.com/yade/trunk/blob/720a352989c9b1148cf04022d14ec3da233fe563/py/utils.py#L393
[7]https://github.com/yade/trunk/blob/720a352989c9b1148cf04022d14ec3da233fe563/py/utils.py#L419

-- 
You received this bug notification because you are a member of Yade
developers, which is subscribed to Yade.
https://bugs.launchpad.net/bugs/1804621

Title:
  bodyNumInteractionsHistogram broken

Status in Yade:
  New

Bug description:
  See https://answers.launchpad.net/yade/+question/676284 and:

  #####################
  O.bodies.append(sphere((0,0,0),1,dynamic=False))
  O.bodies.append(sphere((0,0,1.9),1,dynamic=False))

  O.step()

  print 'BodyNumInteractions Histogram', bodyNumInteractionsHistogram(aabbExtrema())
  ####################

  which returns (with trunk version) :

  ArgumentError: Python argument types in
      yade._utils.bodyNumInteractionsHistogram(list)
  did not match C++ signature:
      bodyNumInteractionsHistogram(boost::python::tuple aabb, bool contactOnly=False)

  
  because my commit [*] changed the Python return type of aabbExtrema() from tuple to list.

  
  Possible (and easiest) fix would be to change all corresponding py::tuple aabb from py::list aabb. Agree ? 

  Or do we want this function to deal with Python tuples and not lists
  ?..


  Jérôme

  [*]
  https://github.com/yade/trunk/commit/1db13fb1183b9e294dc9761da76cfa4fc2791cc1

To manage notifications about this bug go to:
https://bugs.launchpad.net/yade/+bug/1804621/+subscriptions