← Back to team overview

yade-dev team mailing list archive

[Bug 1804621] Re: bodyNumInteractionsHistogram broken

 

Incidentally, two students of mines got strange script failures this week and I realize only now that it was exactly this bug.
I don't want to open a new bug report but it seems "[1] is not well tested" could be one. Please Jerome consider, carefully, the option of reverting the initial commit. Changing so many unrelated functions just to implement a very specific feature is not reasonable. Or, please, make super-sure that it doesn't break anything before changing bottom layers of yade and pushing to trunk, not the case here unfortunately.
Bruno

-- 
You received this bug notification because you are a member of Yade
developers, which is subscribed to Yade.
https://bugs.launchpad.net/bugs/1804621

Title:
  bodyNumInteractionsHistogram broken

Status in Yade:
  New

Bug description:
  See https://answers.launchpad.net/yade/+question/676284 and:

  #####################
  O.bodies.append(sphere((0,0,0),1,dynamic=False))
  O.bodies.append(sphere((0,0,1.9),1,dynamic=False))

  O.step()

  print 'BodyNumInteractions Histogram', bodyNumInteractionsHistogram(aabbExtrema())
  ####################

  which returns (with trunk version) :

  ArgumentError: Python argument types in
      yade._utils.bodyNumInteractionsHistogram(list)
  did not match C++ signature:
      bodyNumInteractionsHistogram(boost::python::tuple aabb, bool contactOnly=False)

  
  because my commit [*] changed the Python return type of aabbExtrema() from tuple to list.

  
  Possible (and easiest) fix would be to change all corresponding py::tuple aabb from py::list aabb. Agree ? 

  Or do we want this function to deal with Python tuples and not lists
  ?..


  Jérôme

  [*]
  https://github.com/yade/trunk/commit/1db13fb1183b9e294dc9761da76cfa4fc2791cc1

To manage notifications about this bug go to:
https://bugs.launchpad.net/yade/+bug/1804621/+subscriptions


References