yade-dev team mailing list archive

[Bruno Chareyre <1804621@xxxxxxxxxxxxxxxxxx>]

Hi Jérôme, I reverted 7c60d78 and friend for you since I did not see reaction yet. We can't keep unsure code in daily builds, sorry.  
Feel free to fix and recommit when everything is sorted out (if it is really worth it, I'm really not sure since the side effects are very intricate).
Bruno

[1]
https://github.com/yade/trunk/commit/ac7647f55b739e324a56d1fcfd04ba63b63513de


** Changed in: yade
   Importance: Undecided => Wishlist

** Changed in: yade
       Status: New => Triaged

** Changed in: yade
     Assignee: Jérôme Duriez (jduriez) => Bruno Chareyre (bruno-chareyre)

** Changed in: yade
       Status: Triaged => Fix Released

-- 
You received this bug notification because you are a member of Yade
developers, which is subscribed to Yade.
https://bugs.launchpad.net/bugs/1804621

Title:
  bodyNumInteractionsHistogram broken

Status in Yade:
  Fix Released

Bug description:
  See https://answers.launchpad.net/yade/+question/676284 and:

  #####################
  O.bodies.append(sphere((0,0,0),1,dynamic=False))
  O.bodies.append(sphere((0,0,1.9),1,dynamic=False))

  O.step()

  print 'BodyNumInteractions Histogram', bodyNumInteractionsHistogram(aabbExtrema())
  ####################

  which returns (with trunk version) :

  ArgumentError: Python argument types in
      yade._utils.bodyNumInteractionsHistogram(list)
  did not match C++ signature:
      bodyNumInteractionsHistogram(boost::python::tuple aabb, bool contactOnly=False)

  
  because my commit [*] changed the Python return type of aabbExtrema() from tuple to list.

  
  Possible (and easiest) fix would be to change all corresponding py::tuple aabb from py::list aabb. Agree ? 

  Or do we want this function to deal with Python tuples and not lists
  ?..


  Jérôme

  [*]
  https://github.com/yade/trunk/commit/1db13fb1183b9e294dc9761da76cfa4fc2791cc1

To manage notifications about this bug go to:
https://bugs.launchpad.net/yade/+bug/1804621/+subscriptions