yade-dev team mailing list archive

[Sacha Duverger <sacha.duverger@xxxxxxxxx>]

Hello,

Thanks for adding me on Gitlab, I have a few questions though :

1)
I cloned the trunk from gitlab on my machine and made the changes on domaindecomposition.py (I was using yade2020.01a before). 
How should I proceed now to request the merge ?

I was thinking of simply doing:
- commit the changes locally on my machine
- push the commit with “git push origin master"

2)
There are two changes I made to domaindecomposition.py. The first one is easily spottable and should change the returned value of a method. The second one doesn’t change the returned value because the variable on which the supposed mistake is isn’t used. However, I merged the loop in which the supposed mistake is with another similar one, and I took off a “if” that didn’t seem necessary. 
Should I commit only the corrections or the improvements as well ? And should I commit all those changes at once or make several commits ? 

3)
I had to compile YADE again since I started from the trunk on Gitlab. I tried to compile it using 10 cores but it failed. When I tried to compile it again using only one core it worked. 
Should I detail this problem as a question on the launchpad or is there a more appropriate place for this kind of problems ?

Thank you and have a nice week end,

Sacha

> On 15 May 2020, at 14:48, Bruno Chareyre <bruno.chareyre@xxxxxxxxxxxxxxx> wrote:
> 
> Hi Sacha,
> Thank you for reaching us. It is good that someone will try that independently.
> Please note that the documentation is still lacking but it more up to date in a temporary branch [1]. 
> I'm curious to see the problems you found.
> Regards
> Bruno
> 
> [1] https://gitlab.com/yade-dev/trunk/-/blob/MPIdoc/doc/sphinx/mpy.rst <https://gitlab.com/yade-dev/trunk/-/blob/MPIdoc/doc/sphinx/mpy.rst>
> On Fri, 15 May 2020 at 13:52, Janek Kozicki (yade) <jkozicki-yade@xxxxxxxxx <mailto:jkozicki-yade@xxxxxxxxx>> wrote:
> Looks like Bruno is a bit busy :-) So I have added you o our project.
> 
> We are looking forward to your merge requests! :)
> 
> best regards
> Janek
> 
> Robert Caulk said:     (by the date of Thu, 14 May 2020 19:22:48 +0200)
> 
> > bisectionDecomposition.py is objectively better than
> > domaindecomposition.py. However, there is still utility in being able to
> > manually control the subdomains with domaindecomposition.py. And therefore
> > your corrections are very welcome :-)
> > 
> > On Thu, May 14, 2020 at 6:52 PM Sacha Duverger <sacha.duverger@xxxxxxxxx <mailto:sacha.duverger@xxxxxxxxx>>
> > wrote:
> > 
> > > Thank you for welcoming me,
> > >
> > > I use domaindecomposition.py because the exemple I tried ([1]) used it.
> > > It wasn’t up to date with the current version of YADE. Now that you
> > > mention bisectionDecomposition.py, I’m beginning to think that I should
> > > have used [2] instead.
> > >
> > > [1] :
> > > https://gitlab.com/yade-dev/trunk/-/blob/master/examples/mpi/testMPI_3D.py <https://gitlab.com/yade-dev/trunk/-/blob/master/examples/mpi/testMPI_3D.py>
> > > [2] :
> > > https://gitlab.com/yade-dev/trunk/-/blob/master/examples/mpi/testMPI_3D_bisection.py <https://gitlab.com/yade-dev/trunk/-/blob/master/examples/mpi/testMPI_3D_bisection.py>
> > >
> > >
> > > On 14 May 2020, at 15:43, Robert Caulk <rob.caulk@xxxxxxxxx <mailto:rob.caulk@xxxxxxxxx>> wrote:
> > >
> > > Out of curiosity, why are you using domaindecomposition.py instead of
> > > bisectionDecomposition.py?
> > >
> > > On Thu, May 14, 2020 at 2:39 PM Janek Kozicki (yade) <
> > > jkozicki-yade@xxxxxxxxx <mailto:jkozicki-yade@xxxxxxxxx>> wrote:
> > >
> > >> Hi, welcome here! :)
> > >>
> > >> Bruno is leading the MPI programming effort, I will let him do the honors
> > >> ;)
> > >> BTW, he is in the middle of finishing the docs :)
> > >>
> > >> best regards
> > >> Janek
> > >>
> > >>
> > >> Sacha Duverger said:     (by the date of Thu, 14 May 2020 13:39:37 +0200)
> > >>
> > >> > Hello,
> > >> >
> > >> > I’ve been using YADE since over a year now. I recently tried to use the
> > >> MPI parallelisation and I believe I found a couple of errors in the
> > >> py/domaindecomposition.py script.
> > >> >
> > >> > Could I join the yade-dev team so I can suggest my corrections? My
> > >> username on gitlab is @schd .
> > >> >
> > >> >
> > >> > Thank you,
> > >> >
> > >> > Sacha Duverger
> > >> > _______________________________________________
> > >> > Mailing list: https://launchpad.net/~yade-dev <https://launchpad.net/~yade-dev>
> > >> > Post to     : yade-dev@xxxxxxxxxxxxxxxxxxx <mailto:yade-dev@xxxxxxxxxxxxxxxxxxx>
> > >> > Unsubscribe : https://launchpad.net/~yade-dev <https://launchpad.net/~yade-dev>
> > >> > More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
> > >>
> > >>
> > >> --
> > >> Janek Kozicki, PhD. DSc. Arch. Assoc. Prof.
> > >> Gdańsk University of Technology
> > >> Faculty of Applied Physics and Mathematics
> > >> Department of Theoretical Physics and Quantum Information
> > >> --
> > >> http://yade-dem.org/ <http://yade-dem.org/>
> > >> http://pg.edu.pl/jkozicki <http://pg.edu.pl/jkozicki> (click English flag on top right)
> > >>
> > >> _______________________________________________
> > >> Mailing list: https://launchpad.net/~yade-dev <https://launchpad.net/~yade-dev>
> > >> Post to     : yade-dev@xxxxxxxxxxxxxxxxxxx <mailto:yade-dev@xxxxxxxxxxxxxxxxxxx>
> > >> Unsubscribe : https://launchpad.net/~yade-dev <https://launchpad.net/~yade-dev>
> > >> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
> > >>
> > >
> > >
> 
> 
> -- 
> --
> Janek Kozicki, PhD. DSc. Arch. Assoc. Prof.
> Gdańsk University of Technology
> Faculty of Applied Physics and Mathematics
> Department of Theoretical Physics and Quantum Information
> --
> http://yade-dem.org/ <http://yade-dem.org/>
> http://pg.edu.pl/jkozicki <http://pg.edu.pl/jkozicki> (click English flag on top right)
> 
> 
> 
> 
> -- 
> -- 
> _______________
> Bruno Chareyre
> Associate Professor
> ENSE³ - Grenoble INP
> Lab. 3SR
> BP 53
> 38041 Grenoble cedex 9
> Tél : +33 4 56 52 86 21
> ________________
> 
> Email too brief?
> Here's why: email charter <https://marcuselliott.co.uk/wp-content/uploads/2017/04/emailCharter.jpg>