← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1110973] Re: Some object comparsion syntax nits

 

** Changed in: nova
       Status: Fix Committed => Fix Released

** Changed in: nova
    Milestone: None => grizzly-3

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1110973

Title:
  Some object comparsion syntax nits

Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  There are some lines in nova where instead of "if X is not Y", it uses
  "if not X is Y"

  Since "is not" seems to be the consensus and is more intuitive, object
  inequality evaluations should use "is not"

  $ grep -R " not " nova | grep " is " | grep -E ":\W*if" | wc -lc
      315   22423
  $ grep -R " not " nova | grep " is " | grep -v " is not " | grep -E ":\W*if" | wc -lc
       16    1301

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1110973/+subscriptions