← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1108631] Re: Recoverable error should be logged at WARN level

 

** Changed in: horizon
       Status: Fix Committed => Fix Released

** Changed in: horizon
    Milestone: None => grizzly-3

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1108631

Title:
  Recoverable error should be logged at WARN level

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  In the error handling of horizon, recoverable error is logged at ERROR
  LEVEL.

      if issubclass(exc_type, RECOVERABLE):
          wrap = True
          if not force_silence and not handled and (not ignore or force_log):
              log_method(error_color("Recoverable error: %s" % exc_value))
          if not ignore and not handled:
              messages.error(request, message or exc_value)
          if redirect:
              raise Http302(redirect)
          if not escalate:
              return RecoverableError # return to normal code flow

  Recoverable exceptions are typically application exception or
  validation error that the user can fix.

  Logging recoverable error as ERROR in the log might cause false alarm
  if there are log file monitoring is in place that looks for ERRORs.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1108631/+subscriptions