← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1102313] Re: Redundant code in quantum.apit.api_common

 

** Changed in: quantum
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to quantum.
https://bugs.launchpad.net/bugs/1102313

Title:
  Redundant code in quantum.apit.api_common

Status in OpenStack Quantum (virtual network service):
  Fix Released

Bug description:
  None is redundant in line 3
  Line 8 is not required

    1        for param in params:
    2            param_name = param['param-name']
    3            param_value = data.get(param_name, None)
    4            # If the parameter wasn't found and it was required, return 400
    5            if param_value is None and param['required']:
    6                msg = ("Failed to parse request. " +
    7                       "Parameter: " + param_name + " not specified")
    8                for line in msg.split('\n'):
    9                    LOG.error(line)
  10                raise exc.HTTPBadRequest(msg)
  11            data[param_name] = param_value or param.get('default-value')
  12        return body

To manage notifications about this bug go to:
https://bugs.launchpad.net/quantum/+bug/1102313/+subscriptions