← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1076813] Re: improvements to API validation logic

 

** Changed in: quantum
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to quantum.
https://bugs.launchpad.net/bugs/1076813

Title:
  improvements to API validation logic

Status in OpenStack Quantum (virtual network service):
  Fix Released

Bug description:
  The last round of reviews for https://review.openstack.org/#/c/14219/
  specified a few more areas for improvement in validation code that we
  could do.

  One is to no longer catch generic Exceptions like AttributeError, etc.
  and convert them into HTTP 400s, as it is possible that those errors
  are actually the result of internal server errors (i.e., should be
  HTTP 500s).  Ideally, we could catch these closer to the source where
  it was possible to tell if they happened during input validation
  (i.e.., are a 400) or later in server processing (i.e., are a 500).

  Also, there are a couple cases where the validation messages could be
  improved, in particular, places where we say something like "invalid
  fixes ip", but then print the entire list of fixed IPs.  Ideally we
  would either report that the item is not a list, or indicate that a
  particular list member was detected as invalid.

To manage notifications about this bug go to:
https://bugs.launchpad.net/quantum/+bug/1076813/+subscriptions