yahoo-eng-team team mailing list archive

[Brian Waldon <bcwaldon+launchpad@xxxxxxxxx>]

** Changed in: glance
       Status: Incomplete => Opinion

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1113403

Title:
  code style is inconsistency with PEP8

Status in OpenStack Image Registry and Delivery Service (Glance):
  Opinion

Bug description:
  style of a few code in glance is inconsistency with PEP8

  most are inconsistent with indentation defined in PEP8(continuation
  line over-indent or continuation line indentation is not a multiple of
  four)

  below are part of result of './run_tests.sh -p':

  ./glance/db/sqlalchemy/api.py:844:20: E127 continuation line over-indented for visual indent
  ./glance/db/sqlalchemy/api.py:845:20: E127 continuation line over-indented for visual indent
  ./glance/db/sqlalchemy/api.py:858:19: E127 continuation line over-indented for visual indent
  ./glance/db/sqlalchemy/api.py:859:19: E127 continuation line over-indented for visual indent
  ./glance/db/sqlalchemy/api.py:860:19: E127 continuation line over-indented for visual indent
  ./glance/db/sqlalchemy/api.py:861:19: E127 continuation line over-indented for visual indent
  ./glance/db/sqlalchemy/migrate_repo/versions/015_quote_swift_credentials.py:54:26: E127 continuation line over-indented for visual indent
  ./glance/db/sqlalchemy/migrate_repo/versions/015_quote_swift_credentials.py:59:21: E127 continuation line over-indented for visual indent
  ./glance/db/sqlalchemy/migrate_repo/versions/015_quote_swift_credentials.py:60:21: E127 continuation line over-indented for visual indent
  ./glance/image_cache/client.py:102:21: E127 continuation line over-indented for visual indent
  ./glance/image_cache/client.py:104:21: E127 continuation line over-indented for visual indent
  ./glance/image_cache/client.py:106:21: E127 continuation line over-indented for visual indent
  ./glance/image_cache/client.py:108:21: E127 continuation line over-indented for visual indent
  ./glance/image_cache/client.py:110:21: E127 continuation line over-indented for visual indent
  ./glance/image_cache/client.py:111:21: E127 continuation line over-indented for visual indent
  ./glance/image_cache/client.py:113:21: E127 continuation line over-indented for visual indent
  ./glance/tests/functional/v1/test_api.py:650:16: E121 continuation line indentation is not a multiple of four
  ./glance/tests/functional/v1/test_api.py:662:16: E121 continuation line indentation is not a multiple of four
  ./glance/tests/functional/v1/test_api.py:672:16: E121 continuation line indentation is not a multiple of four
  ./glance/tests/functional/v1/test_api.py:682:16: E121 continuation line indentation is not a multiple of four
  ./glance/tests/functional/v1/test_api.py:694:16: E121 continuation line indentation is not a multiple of four
  ./glance/tests/functional/v1/test_api.py:706:16: E121 continuation line indentation is not a multiple of four
  ./glance/tests/functional/v1/test_api.py:718:16: E121 continuation line indentation is not a multiple of four
  ./glance/tests/functional/v1/test_api.py:731:16: E121 continuation line indentation is not a multiple of four
  ./glance/tests/functional/v1/test_api.py:742:16: E121 continuation line indentation is not a multiple of four

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1113403/+subscriptions