yahoo-eng-team team mailing list archive

[Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>]

** Changed in: quantum
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to quantum.
https://bugs.launchpad.net/bugs/1133253

Title:
  Some database accesses in NEC plugin do not support subtransaction

Status in OpenStack Quantum (virtual network service):
  Fix Released

Bug description:
  Some database accesses in NEC plugin did not support subtransaction.
  There are three type below.

  
  (a) subtransactions=True is not specified.
  quantum/plugins/nec/db/nec_plugin_base.py: update_packet_filter()
          with context.session.begin():
              pf_entry = nmodels.PacketFilter(**params)
              context.session.add(pf_entry)

  (b) transaction commit is not ensured.
  quantum/plugins/nec/nec_plugin.py:  update_packet_filter()
          old_pf = super(NECPluginV2, self).get_packet_filter(context, id)
          new_pf = super(NECPluginV2, self).update_packet_filter(context, id,
                                                                 packet_filter)

  (c) using session.flush(). It works but with session.begin(subtransactions=True) is recommended.
  quantum/plugins/nec/db/api.py: add_ofc_item()
          item = model(**params)
          session.add(item)
          session.flush()

To manage notifications about this bug go to:
https://bugs.launchpad.net/quantum/+bug/1133253/+subscriptions