yahoo-eng-team team mailing list archive

[Dolph Mathews <1131490@xxxxxxxxxxxxxxxxxx>]

Looking at this again, I'm not sure that the InvocationError should be
caught? It looks like the invocation of PEP8 is failing as it should
(there's a PEP8 violation causing the command to return non-zero).

** Changed in: keystone
       Status: New => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Keystone.
https://bugs.launchpad.net/bugs/1131490

Title:
  run_tests.sh pep test not catching InvocationError

Status in OpenStack Identity (Keystone):
  Invalid

Bug description:
  When I run 
  openstack@plwdevstack:/opt/stack/keystone$ ./run_tests.sh -p --pep-8
  it works fine and gives me no pep error. 
  However, when I uploaded code for review, Jenkins captured a pep specific error as below: 

  2013-02-21 23:26:27.299 |   /home/jenkins/workspace/gate-keystone-pep8$ /home/jenkins/workspace/gate-keystone-pep8/.tox/pep8/bin/pep8 --exclude=.venv,.tox,dist,doc,openstack,vendor,*egg --repeat --show-source . 
  2013-02-21 23:26:31.284 | ./tests/test_backend_ldap.py:376:9: E128 continuation line under-indented for visual indent
  2013-02-21 23:26:31.284 |         self.identity_api.get_group, group['id'])
  2013-02-21 23:26:31.284 |         ^
  2013-02-21 23:26:31.292 | ERROR: InvocationError: '/home/jenkins/workspace/gate-keystone-pep8/.tox/pep8/bin/pep8 --exclude=.venv,.tox,dist,doc,openstack,vendor,*egg --repeat --show-source .'
  2013-02-21 23:26:31.293 | ___________________________________ summary ____________________________________
  2013-02-21 23:26:31.293 | ERROR:   pep8: commands failed

  where in the test_backend_ldap.py I had
          self.assertRaises(exception.GroupNotFound,
          self.identity_api.get_group, group['id'])

  I verified that running  " ./run_tests.sh -p --pep-8" was catching
  different types of pep-8 specific errors (e.g. indentation error)
  except above one.

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1131490/+subscriptions