yahoo-eng-team team mailing list archive

[Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>]

** Changed in: nova
       Status: Fix Committed => Fix Released

** Changed in: nova
    Milestone: None => grizzly-rc1

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1132742

Title:
  Make libguestfs API calls run in a thread pool

Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  In the following commit direct use of the libguestfs API was
  introduced:

    commit 74e38f1baefb020de30aa19745964bef9ad7254a
    Author: Daniel P. Berrange <berrange@xxxxxxxxxx>
    Date:   Tue Nov 13 11:03:26 2012 +0000

      Introduce a VFS implementation backed by the libguestfs APIs
      
      This implements the VFS APIs using the libguestfs Python APIs.
      This removes the need to map the virtual disk image into the
      host filesystem, and thus avoids potential symlink attacks
      from the guest filesystem. It also performs better than the
      libguestfs FUSE module
      
      blueprint: virt-disk-api-refactoring
      Change-Id: I3202ec9479f22aa1ae461cab24968e54be1642c1
      Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx>

  
  as this is a native API though and Nova uses eventlet, this has the effect of blocking all green threads. To fix this concurrency bottleneck the code must be made to use the eventlet tpool for invoking libguestfs APIs.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1132742/+subscriptions