← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1153841] Re: cells.utils split_cell_and_item should not raise a ValueError when there's no cell

 

** Changed in: nova
       Status: Fix Committed => Fix Released

** Changed in: nova
    Milestone: None => grizzly-rc1

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1153841

Title:
  cells.utils split_cell_and_item should not raise a ValueError when
  there's no cell

Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  all the places where 'split_cell_and_item' check for the returned
  'cell' being None, but what actually happens if you call it with no
  cell, is that it returns [item].

  When the method is called like this (as it is in most places):

  cell, item = split_cell_and_item(togetherness)

  It raises:

  ValueError: need more than 1 value to unpack

  ----

  If you call it with no cell, it should just return a pair with None
  for the cell and the item.

  eg.

  => 'path!to!cell@item'
  <= 'path!to!cell', 'item'

  => 'item'
  <= None, 'item'

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1153841/+subscriptions