yahoo-eng-team team mailing list archive

[Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>]

** Changed in: nova
       Status: Fix Committed => Fix Released

** Changed in: nova
    Milestone: None => grizzly-rc1

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1134622

Title:
  hacking.py crashes on module AttributeError

Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  When running nova's hacking.py in tempest, it crashes due to an
  AttributeError.

  $ python ../nova/tools/hacking.py --ignore=E122,E125,E126,N404,N302,N304 --repeat --show-source --exclude=.venv,.tox,dist,doc,openstack,*egg . 
  6 imports missing in this test environment
  Traceback (most recent call last):
    File "../nova/tools/hacking.py", line 630, in <module>
      pep8._main()
    File "/Library/Python/2.7/site-packages/pep8.py", line 1917, in _main
      report = pep8style.check_files()
    File "/Library/Python/2.7/site-packages/pep8.py", line 1586, in check_files
      self.input_dir(path)
    File "../nova/tools/hacking.py", line 89, in input_dir
      runner(os.path.join(root, filename))
    File "/Library/Python/2.7/site-packages/pep8.py", line 1597, in input_file
      return fchecker.check_all(expected=expected, line_offset=line_offset)
    File "/Library/Python/2.7/site-packages/pep8.py", line 1340, in check_all
      self.check_logical()
    File "/Library/Python/2.7/site-packages/pep8.py", line 1280, in check_logical
      for result in self.run_check(check, argument_names):
    File "../nova/tools/hacking.py", line 253, in nova_import_rules
      if not is_module(mod):
    File "../nova/tools/hacking.py", line 219, in is_module
      res = is_module_for_sure(mod)
    File "../nova/tools/hacking.py", line 203, in is_module_for_sure
      module = __import__(mod)
    File "/Users/jogo/Develop/openstack/tempest/stress/test_server_actions.py", line 81, in <module>
      class VerifyRebootVM(pending_action.PendingServerAction):
    File "/Users/jogo/Develop/openstack/tempest/stress/test_server_actions.py", line 83, in VerifyRebootVM
      States = stress.utils.enum('REBOOT_CHECK', 'ACTIVE_CHECK')
  AttributeError: 'module' object has no attribute 'enum'

  
  As hacking.py is only a style checker it should ignore the AttributeError.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1134622/+subscriptions