← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1133103] Re: pep8 returns false N302 for missing import

 

** Changed in: nova
       Status: Fix Committed => Fix Released

** Changed in: nova
    Milestone: None => grizzly-rc1

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1133103

Title:
  pep8 returns false N302 for missing import

Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  The pep8 for patch set 6 of https://review.openstack.org/#/c/22707
  returned invalid results. http://logs.openstack.org/22707/6/check
  /gate-nova-pep8/21479/console.html.gz

  
  pep8 reported 
  './nova/virt/vmwareapi/vim.py:32:1: N302  import only modules.'from nova.virt.vmwareapi import error_util' does not import a module'

   because https://review.openstack.org/#/c/22707/6..7/nova/openstack/common/db/exception.py
   had in invalid import.

  The current logic compares the last word of the module name along with
  the last word of the exception msg, and if they are not the same a
  module is missing.  This check should also make sure the words "cannot
  import" aren't in the exception msg.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1133103/+subscriptions