yahoo-eng-team team mailing list archive

[OpenStack Hudson <1131857@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/25105
Committed: http://github.com/openstack/cinder/commit/d87259417c53d464dd3ec2b399faf22e65e1265c
Submitter: Jenkins
Branch:    milestone-proposed

commit d87259417c53d464dd3ec2b399faf22e65e1265c
Author: Dan Prince <dprince@xxxxxxxxxx>
Date:   Tue Mar 19 19:37:47 2013 -0400

    Updates to OSAPI sizelimit middleware.
    
    Updates the OSAPI sizelimit middleware so that we use avoid calling
    len on a request body which could cause a really large request
    to get buffered into memory.
    
    Also updates the middleware to return HTTP 413 which is a more
    correct error code in this case (previously it returned just 400).
    
    Fixes LP Bug #1131857.
    
    Change-Id: Iff6cb0c24bc21e5a1d5dd4cf29acb0b4ee221708
    (cherry picked from commit 3fe81851bab39a1466d8744b372b5a287b4db93d)


** Changed in: cinder
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1131857

Title:
  avoid calling len in sizelimit middleware

Status in Cinder:
  Fix Released
Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  Nova's sizelimit middleware should avoid using len() which could cause
  extra memory buffering to occur on large requests.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1131857/+subscriptions