yahoo-eng-team team mailing list archive

[OpenStack Hudson <1158247@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/25635
Committed: http://github.com/openstack/glance/commit/13f8f0082faf70debb3c56e01e7492f29913e783
Submitter: Jenkins
Branch:    milestone-proposed

commit 13f8f0082faf70debb3c56e01e7492f29913e783
Author: John Bresnahan <jbresnah@xxxxxxxxxx>
Date:   Fri Mar 22 11:26:12 2013 -1000

    Directly verifying that time and socket are monkey patched
    
    This tests makes sure that thew wsgi object properly monkey patched
    two needed modules, socket and time.  In bug 988099 it was noted that
    the time module was not being monkey patched.  A test was added that
    unfortunately introduced a bug and a patch to revert it is here:
    https://review.openstack.org/#/c/25107/ in order to fix bug 1158247.
    This patch allows for test_server_monkey_patch.py to be removed
    without losing the verification of that functionality.
    
    Fixes bug 1158247
    Change-Id: I8da6b04d0cc0dae00ba52e5b7350a5e01a76cadb


** Changed in: glance
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1158247

Title:
  test_server_monkey_patch leaves orphaned process

Status in OpenStack Image Registry and Delivery Service (Glance):
  Fix Released
Status in “glance” package in Ubuntu:
  Fix Released
Status in “glance” source package in Raring:
  Fix Released

Bug description:
  When running the test_server_monkey_patch test against distro packages
  in Ubuntu raring, a python process gets left running; this causes
  issue in the official distro builders as that process still has an
  open handle, causing the build to spin and hit timeouts:

  jamespage@hendrix:~/src/ubuntu/thelab/daily-fixes/glance$ ./run_tests.sh -N -P glance.tests.functional.test_server_monkey_patch
  glance.tests.functional.test_server_monkey_patch.TestClientServerInteractions.test_time_is_monkey_patched ... ok

  ----------------------------------------------------------------------
  Ran 1 test in 1.045s

  OK
  jamespage@hendrix:~/src/ubuntu/thelab/daily-fixes/glance$ ps -ef | grep nose
  1000     18305     1  0 11:20 pts/5    00:00:00 /usr/bin/python /usr/bin/nosetests glance.tests.functional.test_server_monkey_patch
  1000     18307  5321  0 11:20 pts/5    00:00:00 grep --color=auto nose

  I see exactly the same when running the test using venv against
  master:

  jamespage@hendrix:~/src/upstream/glance$ ./run_tests.sh glance.tests.functional.test_server_monkey_patch
  glance.tests.functional.test_server_monkey_patch.TestClientServerInteractions.test_time_is_monkey_patched ... ok

  ----------------------------------------------------------------------
  Ran 1 test in 1.066s

  OK
  jamespage@hendrix:~/src/upstream/glance$ ps -aef | grep nose
  1000     20145     1  0 11:30 pts/5    00:00:00 /usr/bin/python /usr/bin/nosetests glance.tests.functional.test_server_monkey_patch
  1000     20147  5321  0 11:30 pts/5    00:00:00 grep --color=auto nose

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1158247/+subscriptions