yahoo-eng-team team mailing list archive

[Launchpad Bug Tracker <1084450@xxxxxxxxxxxxxxxxxx>]

[Expired for quantum because there has been no activity for 60 days.]

** Changed in: quantum
       Status: Incomplete => Expired

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to quantum.
https://bugs.launchpad.net/bugs/1084450

Title:
  dhcp lease time feature does not work

Status in OpenStack Quantum (virtual network service):
  Expired

Bug description:
  now, dhcp agent will notify the plugin the lease time, the plugin's update_fixed_ip_lease_expiration will receive this message. But it seems we have a bug with this function:
      def update_fixed_ip_lease_expiration(self, context, network_id,
                                           ip_address, lease_remaining):

          expiration = (timeutils.utcnow() +
                        datetime.timedelta(seconds=lease_remaining))

          query = context.session.query(models_v2.IPAllocation)
          query = query.filter_by(network_id=network_id, ip_address=ip_address)

          try:
              fixed_ip = query.one()
              fixed_ip.expiration = expiration
              # we need to add following codes to save the lease time notification from dhcp agent
              #with context.session.begin(subtransactions=True):
               #   context.session.add(fixed_ip)
          except exc.NoResultFound:
              LOG.debug(_("No fixed IP found that matches the network "
                          "%(network_id)s and ip address %(ip_address)s."),
                        locals())

  In fact, my opinion is to remove the notification totally, and modify
  the expiration to a default time later when we delete port.

  With dhcp agents to notify the quantum server now and then will
  influence the server's performance a lot in large deployment.

To manage notifications about this bug go to:
https://bugs.launchpad.net/quantum/+bug/1084450/+subscriptions