yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #01948
[Bug 1152866] Re: notifier_kombu should not retry forever
** Changed in: glance/grizzly
Importance: Undecided => Medium
** Changed in: glance/grizzly
Status: New => Fix Released
** Changed in: glance/grizzly
Milestone: None => 2013.1
** Changed in: glance/grizzly
Assignee: (unassigned) => Eric Windisch (ewindisch)
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1152866
Title:
notifier_kombu should not retry forever
Status in OpenStack Image Registry and Delivery Service (Glance):
Fix Released
Status in Glance grizzly series:
Fix Released
Bug description:
There is a rabbit_max_retries option, but this is not working
correctly.
First, the configvar is defined as a StrOpt. This means that the check
against the integer retry_attempts will fail.
Secondly, rabbit_max_retries is tested as a boolean before comparing
against retry_attempts. With the value 0, this would be false and the
setting rabbit_max_retries=0 would actually retry indefinitely, which
is not the obvious behavior.
FYI - It turns out that this code is blocking. If notifications cannot
be sent, if a RabbitMQ server cannot be reached, Glance will simply
block on attempting to send notifications, while API requests timeout.
As such, until that is rectified, having the max_retries functional is
quite handy.
To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1152866/+subscriptions